[Five Aces]

So I am filling in my spare time by following poorly documented tutorials to expand my PHP understanding. (A text book would be most excellent, but I have not had any time to go looking for one.) At any rate, while playing around with this particular tutorial, I get the same error, again and again. Some rudimentary thinking on my behalf has determined that I have no idea how to go about rectifying my problem, here.

Exact error message:

Call to undefined method System::getsettings() in C:\xampp\htdocs\TEST\includes\db.php on line 16

This is in reference to me calling the getSettings() function that exists in the System class in system.php. I'm probably using some horribly incorrect syntax, or some such simple error, but it is beyond me.

The files in question (they exist in the same directory):

system.php

Spoiler

<?php

//class for defining database login credentials
//this is expanded by other classes for validation etc.
class System {

  var $settings;
  
  function getSettings() {
  
    $settings['dbhost'] = 'localhost';  //connection to database
    $settings['dbuser'] = 'cmsuser';  //username for access to database
    $settings['dbpass'] = 'EVEN THOUGH IT IS LOCAL, I BEST NOT SAY'; //password for access to database
    $settings['dbname'] = 'cmsdatabase';  //name of database
    
    return $settings;
    
  }
  
}

?>

db.php

Spoiler

<?php

//call system.php which contains System class
require_once 'system.php';

class DBconnect extends System {

  var $theQuery;
  var $con;
  
  //runs automatically when DBconnect class is called
  //connects to the database
  function DBconnect() {
    
    //load settings as defined in the System class (system.php)
    $settings = System::getSettings();
    
    //get the particular settings we need to connect to the MySQL database
    $dbhost = $settings['dbhost'];
    $dbuser = $settings['dbuser'];
    $dbpass = $settings['dbpass'];
    $dbname = $settings['dbname'];
    
    //connect to the database
    $this->con = mysql_connect($dbhost, $dbuser, $dbpass);
    mysql_select_db($dbname);
    register_shutdown_function(array(&$this, 'close'));
  
  }
  
  //excecute database queries
  function query($query) {
  
    $this->theQuery = $query;
    return mysql_query($query, $this->con);
    
  }
  
  //get array for results of query function
  function getArray($result) {
  
    return mysql_fetch_array($result);
    
  }
  
  //close connection to database
  function close() {
  
    mysql_close($this->con);
    
  }
  
}

?>

Any and all help is, as always, much appreciated!

[stategamer]

if u look in the first file ur not escaping ur '.
And when u look at the colours ull see its going wrong somewhere :P

i see u edit-ed it, are u still getting the problem?


oh and i believe u can only use "::" on static functions.


oh and did u try using 'public,private,static,protected' ?

Quote

try doing this :
//load settings as defined in the System class (system.php)
$settings = System::getSettings();


change that into :

//load settings as defined in the System class (system.php)
$settings = System->getSettings();

This post has been edited by stategamer: 09 November 2009 - 07:18 AM

[Five Aces]

stategamer, on 09 November 2009 - 10:50 PM, said:

if u look in the first file ur not escaping ur '.
And when u look at the colours ull see its going wrong somewhere :P

i see u edit-ed it, are u still getting the problem?


oh and i believe u can only use "::" on static functions.


oh and did u try using 'public,private,static,protected' ?

Yeah, I edited out the password, but used the word "it's", which threw out the code (at least the colouring). Only noticed after I posted.

I'm still getting the problem.

How would I make that a static function? (Will Google, in the meantime.)


e: Mkay, went to the php.net page concerning such matters, and only confused myself more. Adding static or public (or both) to the function did not change my error.

Also, changing to that arrow cause me to get a parse error instead.


e2: Swapping out System::getSettings(); for parent::getSettings(); returns the same error message. (i.e. "System::getsettings()" is still undefined.) At the very least, it tells me it's having no trouble accepting that System exists (not that I needed any extra proof - it wouldn't get past the "extends" line if that was the problem), it just refuses to believe that getSettings() is a valid function...

[No1 1000]

    //load settings as defined in the System class (system.php)
    $settings = System::getSettings();

$this->getSettings();

or if it's static, perhaps this::getSettings().


Or you could just copy the method and values over to the DB class, and scratch the whole extends bit.

[Five Aces]

Found my issue.

I decided to remove the whole "call one class file into the other" thing, because I suspected it was more to do with properly locating the parent class. How best to explain is beyond me, but I know that when I changed the name of the class being extended to something that didn't exist, I got an error message. So I cut the crap, and pasted it straight in.

And, of course, it worked the first time.

Having found my issue - the "require_once" function - it was only a few seconds until I had my answer in front of me. Even though I was calling the file into a file that coexisted in the same directory, it was all taking place in another file in yet another directory. (Basically, I have two folders in a directory. The two class files were in one, and the script calling them was in another.) As a result, the "require_once" command was trying to find it in the wrong directory - I had wrongfully assumed that the command would search where the file was located, not where the file was being called.

Thanks for the help, though!



(Just found this, which sums it up nicely: http://ca3.php.net/m...quire.php#87191 )